add RebalanceConfig class to replace use of BaseConfiguration for rebalance configs #11730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11730 +/- ##
============================================
- Coverage 63.09% 63.01% -0.08%
Complexity 1118 1118
============================================
Files 2342 2342
Lines 125890 125895 +5
Branches 19360 19362 +2
============================================
- Hits 79434 79337 -97
- Misses 40807 40895 +88
- Partials 5649 5663 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klsince
force-pushed
the
make_rebalance_config_class
branch
from
805e95d
to
a6e52e0
Compare
klsince
force-pushed
the
make_rebalance_config_class
branch
from
a6e52e0
to
8a0f6ea
Compare
Jackie-Jiang
reviewed
Oct 3, 2023
pinot-spi/src/main/java/org/apache/pinot/spi/utils/RebalanceConfigConstants.java
Outdated
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java
Show resolved
Hide resolved
...c/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignment.java
Outdated
Show resolved
Hide resolved
...ller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Oct 4, 2023
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
Outdated
Show resolved
Hide resolved
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
make_rebalance_config_class
branch
from
577da49
to
6b3bbd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the configs for table rebalance get more and more, it's more consistent and manageable to define a class for them, thus RebalanceConfig class is added in this PR. Another need for this class is to de/serialize the configs to enable retry mechanism for rebalance as to be added in another PR.
The changes are pretty mechanical, with a few cleanup and quick fixes found along the way.