Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11085: Added commons-configuration2 dependency. #11792

Merged

Conversation

abhioncbr
Copy link
Contributor

As per the issue.

  • This is related to the first task i.e. adding the commons-configuration2 dependency in the root pom file.
  • Also added an exclusion for the commons-configuration2 jar import through hadoop-common dependency.

cc @Jackie-Jiang

@Jackie-Jiang Jackie-Jiang added the dependencies Pull requests that update a dependency file label Oct 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #11792 (2a3996b) into master (314cc03) will decrease coverage by 0.04%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11792      +/-   ##
============================================
- Coverage     63.13%   63.09%   -0.04%     
- Complexity     1117     1139      +22     
============================================
  Files          2342     2343       +1     
  Lines        126007   126320     +313     
  Branches      19381    19423      +42     
============================================
+ Hits          79549    79701     +152     
- Misses        40794    40949     +155     
- Partials       5664     5670       +6     
Flag Coverage Δ
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 63.06% <ø> (+0.01%) ⬆️
java-17 62.96% <ø> (-0.03%) ⬇️
java-20 62.96% <ø> (-0.01%) ⬇️
temurin 63.09% <ø> (-0.04%) ⬇️
unittests 63.08% <ø> (-0.04%) ⬇️
unittests1 67.24% <ø> (-0.03%) ⬇️
unittests2 14.40% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhioncbr
Copy link
Contributor Author

@Jackie-Jiang, can you please retrigger the failing tests, as failure is irrelevant to this change? And also, can you please review it?

Thanks

@xiangfu0
Copy link
Contributor

xiangfu0 commented Oct 13, 2023

I saw an extra file added : pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/pinot-plugins.tar.gz, is it required?
image

@abhioncbr
Copy link
Contributor Author

I saw an extra file added : pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/pinot-plugins.tar.gz, is it required? image

It's not required. Let me delete the unwanted file.

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retriggering since all failure are on jdk-11. let's see the results. otherwise looks good to me.

@abhioncbr
Copy link
Contributor Author

I saw an extra file added : pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/pinot-plugins.tar.gz, is it required? image

It's not required. Let me delete the unwanted file.

Actually, this unwanted file was added last week in this PR; I am deleting it. Thanks

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @xiangfu0 @abhioncbr i missed the doc discussion please kindly take another look before we merge it.

@xiangfu0 xiangfu0 merged commit 1455449 into apache:master Oct 16, 2023
21 checks passed
@abhioncbr abhioncbr deleted the 11085-add-commons-configurtion2-dependency branch April 25, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants