-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11085: Added commons-configuration2 dependency. #11792
11085: Added commons-configuration2 dependency. #11792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11792 +/- ##
============================================
- Coverage 63.13% 63.09% -0.04%
- Complexity 1117 1139 +22
============================================
Files 2342 2343 +1
Lines 126007 126320 +313
Branches 19381 19423 +42
============================================
+ Hits 79549 79701 +152
- Misses 40794 40949 +155
- Partials 5664 5670 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 72 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Jackie-Jiang, can you please retrigger the failing tests, as failure is irrelevant to this change? And also, can you please review it? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retriggering since all failure are on jdk-11. let's see the results. otherwise looks good to me.
Actually, this unwanted file was added last week in this PR; I am deleting it. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @xiangfu0 @abhioncbr i missed the doc discussion please kindly take another look before we merge it.
As per the issue.
commons-configuration2
dependency in the root pom file.commons-configuration2
jar import through hadoop-common dependency.cc @Jackie-Jiang