11085: Pre PinotConfig commons-configuartions2 upgrade #11868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11868 +/- ##
============================================
+ Coverage 61.39% 61.43% +0.03%
Complexity 207 207
============================================
Files 2373 2375 +2
Lines 128276 128519 +243
Branches 19803 19849 +46
============================================
+ Hits 78760 78950 +190
- Misses 43837 43865 +28
- Partials 5679 5704 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhioncbr
force-pushed
the
11085-PinotConfig-configuartions2-upgrade
branch
from
f8ac3a6
to
8588f1e
Compare
abhioncbr
changed the title
| @@ -211,7 +211,7 @@ protected PinotConfiguration getDefaultServerConfiguration() { | |||
| CertBasedTlsChannelAccessControlFactory.class.getName()); | |||
| prop.put("pinot.server.adminapi.access.protocols", "internal"); | |||
| prop.put("pinot.server.adminapi.access.protocols.internal.protocol", "https"); | |||
| prop.put("pinot.server.adminapi.access.protocols.internal.port", "7443"); | |||
| prop.put("pinot.server.adminapi.access.protocols.internal.port", "9443"); | |||
There was a problem hiding this comment.
I always get the issue in binding to this port on my local Mac machine with Intellij, Is it okay to change the port to 9443?
There was a problem hiding this comment.
I plan to randomize ports for tests: #11861
There was a problem hiding this comment.
Reversed my change. Thanks
| public static Stream<String> getKeysStream(Configuration configuration) { | ||
| return StreamSupport.stream(getIterable(configuration.getKeys()).spliterator(), false); | ||
| } | ||
|
|
||
| public static Stream<String> getKeysStream(org.apache.commons.configuration2.Configuration configuration) { |
There was a problem hiding this comment.
Put org.apache.commons.configuration2.Configuration to import section and make the deprecated org.apache.commons.configuration.Configuration to full name.
PinotConfigurationto commons-configuration2.cc: @Jackie-Jiang / @xiangfu0 / @walterddr