Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify PrimaryKey equals method #12574

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 6, 2024

use equalsverifier library to verify PrimaryKey 'equals' method

https://jqno.nl/equalsverifier/

@sullis sullis changed the title verify PrimaryKey equals verify PrimaryKey equals method Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.66%. Comparing base (59551e4) to head (01d6c6b).
Report is 71 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12574      +/-   ##
============================================
- Coverage     61.75%   61.66%   -0.09%     
- Complexity      207     1152     +945     
============================================
  Files          2436     2451      +15     
  Lines        133233   133730     +497     
  Branches      20636    20704      +68     
============================================
+ Hits          82274    82467     +193     
- Misses        44911    45151     +240     
- Partials       6048     6112      +64     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 ?
integration2 ?
java-11 61.66% <ø> (-0.05%) ⬇️
java-21 ?
skip-bytebuffers-false 61.66% <ø> (-0.09%) ⬇️
skip-bytebuffers-true ?
temurin 61.66% <ø> (-0.09%) ⬇️
unittests 61.66% <ø> (-0.09%) ⬇️
unittests1 46.86% <ø> (-0.03%) ⬇️
unittests2 27.64% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis
Copy link
Contributor Author

sullis commented Mar 6, 2024

ready to merge

@Jackie-Jiang Jackie-Jiang merged commit 5282942 into apache:master Mar 6, 2024
21 checks passed
@sullis sullis deleted the sean/PrimaryKey-equalsverifier branch March 6, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants