Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric to track number of segments missed in upsert-snapshot #12581

Merged

Conversation

tibrewalpratik17
Copy link
Contributor

label:

  • observability

Adding a metric to track number of segments missed in upsert-snapshot.

cc @ankitsultana

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.73%. Comparing base (59551e4) to head (e7fdc32).
Report is 89 commits behind head on master.

Files Patch % Lines
...cal/upsert/BasePartitionUpsertMetadataManager.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12581      +/-   ##
============================================
- Coverage     61.75%   61.73%   -0.02%     
- Complexity      207      211       +4     
============================================
  Files          2436     2451      +15     
  Lines        133233   133730     +497     
  Branches      20636    20705      +69     
============================================
+ Hits          82274    82560     +286     
- Misses        44911    45073     +162     
- Partials       6048     6097      +49     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 61.70% <40.00%> (-0.01%) ⬇️
java-21 61.61% <40.00%> (-0.02%) ⬇️
skip-bytebuffers-false 61.72% <40.00%> (-0.03%) ⬇️
skip-bytebuffers-true 61.59% <40.00%> (+33.86%) ⬆️
temurin 61.73% <40.00%> (-0.02%) ⬇️
unittests 61.73% <40.00%> (-0.02%) ⬇️
unittests1 46.93% <20.00%> (+0.04%) ⬆️
unittests2 27.66% <20.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 7fa8bec into apache:master Mar 8, 2024
19 checks passed
@tibrewalpratik17 tibrewalpratik17 deleted the missing_snapshot_metric branch May 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants