Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric to track number of segments missed in upsert-snapshot #12581

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add metric to track number of segments missed in upsert-snapshot #12581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9791998
Add metric to track number of segments missed in upsert-snapshot
tibrewalpratik17 Mar 6, 2024
9194110
address comments
tibrewalpratik17 Mar 7, 2024
e7fdc32
address comments 2
tibrewalpratik17 Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
END_TO_END_REALTIME_INGESTION_DELAY_MS("milliseconds", false),
// Needed to track if valid doc id snapshots are present for faster restarts
UPSERT_VALID_DOC_ID_SNAPSHOT_COUNT("upsertValidDocIdSnapshotCount", false),
UPSERT_PRIMARY_KEYS_IN_SNAPSHOT_COUNT("upsertPrimaryKeysInSnapshotCount", false);
UPSERT_PRIMARY_KEYS_IN_SNAPSHOT_COUNT("upsertPrimaryKeysInSnapshotCount", false),
UPSERT_MISSED_VALID_DOC_ID_SNAPSHOT_COUNT("upsertMissedValidDocIdSnapshotCount", false);

private final String _gaugeName;
private final String _unit;
Expand Down
3 changes: 3 additions & 0 deletions ...c/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,9 @@ protected void doTakeSnapshot() {
ServerGauge.UPSERT_VALID_DOC_ID_SNAPSHOT_COUNT, numImmutableSegments);
_serverMetrics.setValueOfPartitionGauge(_tableNameWithType, _partitionId,
ServerGauge.UPSERT_PRIMARY_KEYS_IN_SNAPSHOT_COUNT, numPrimaryKeysInSnapshot);
_serverMetrics.setValueOfPartitionGauge(_tableNameWithType, _partitionId,
tibrewalpratik17 marked this conversation as resolved.
Show resolved Hide resolved
ServerGauge.UPSERT_MISSED_VALID_DOC_ID_SNAPSHOT_COUNT,
numTrackedSegments - numImmutableSegments - numConsumingSegments);
_logger.info("Finished taking snapshot for {} immutable segments with {} primary keys (out of {} total segments, "
+ "{} are consuming segments) in {} ms", numImmutableSegments, numPrimaryKeysInSnapshot, numTrackedSegments,
numConsumingSegments, System.currentTimeMillis() - startTimeMs);
Expand Down
Loading