use gte(lte) to replace between() which has a bug #12595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
fix_range_index_v2_bug
branch
from
b5737df
to
98f7940
Compare
klsince
force-pushed
the
fix_range_index_v2_bug
branch
from
98f7940
to
f35159b
Compare
Jackie-Jiang
approved these changes
Mar 7, 2024
|
The bug was exposed with a list of 1.3mil+ timestamps of |
richardstartin
approved these changes
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12595 +/- ##
============================================
- Coverage 61.75% 61.71% -0.04%
- Complexity 207 211 +4
============================================
Files 2436 2451 +15
Lines 133233 133730 +497
Branches 20636 20704 +68
============================================
+ Hits 82274 82533 +259
- Misses 44911 45099 +188
- Partials 6048 6098 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a potential bug in between() method, which missed values within the range. It only happened for a certain list of values. In fact, the issue didn't even happen after changing the order of the values in the list. The issue can be worked around by using gte(lte) for now, until the between() method is patched.