-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wildfly-openssl dependency management to root pom #12597
Conversation
99e93ff
to
d7d755b
Compare
d7d755b
to
4ddb6ff
Compare
<artifactId>wildfly-openssl</artifactId> | ||
<version>${wildfly-openssl.version}</version> | ||
</dependency> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Do we also need an entry for org.wildfly.openssl:wildfly-openssl-java
? I see it was there in the original version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's part of org.wildfly.openssl:wildfly-openssl
, so no need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the usage of these libs are coming from ADLS PinotFS, which I think is already deprecated.
Can your team also check and verify the usage and maybe just remove it?
I created a tracking issue: #12598
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12597 +/- ##
==========================================
Coverage 61.75% 61.75%
- Complexity 207 211 +4
==========================================
Files 2436 2451 +15
Lines 133233 133730 +497
Branches 20636 20704 +68
==========================================
+ Hits 82274 82588 +314
- Misses 44911 45049 +138
- Partials 6048 6093 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Move wildfly-openssl dependency management to root pom