Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wildfly-openssl dependency management to root pom #12597

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Mar 7, 2024

Move wildfly-openssl dependency management to root pom

@xiangfu0 xiangfu0 added the dependencies Pull requests that update a dependency file label Mar 7, 2024
<artifactId>wildfly-openssl</artifactId>
<version>${wildfly-openssl.version}</version>
</dependency>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Do we also need an entry for org.wildfly.openssl:wildfly-openssl-java? I see it was there in the original version.

Copy link
Contributor Author

@xiangfu0 xiangfu0 Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's part of org.wildfly.openssl:wildfly-openssl, so no need.

Copy link
Contributor Author

@xiangfu0 xiangfu0 Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the usage of these libs are coming from ADLS PinotFS, which I think is already deprecated.
Can your team also check and verify the usage and maybe just remove it?
I created a tracking issue: #12598

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (59551e4) to head (4ddb6ff).
Report is 88 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #12597    +/-   ##
==========================================
  Coverage     61.75%   61.75%            
- Complexity      207      211     +4     
==========================================
  Files          2436     2451    +15     
  Lines        133233   133730   +497     
  Branches      20636    20704    +68     
==========================================
+ Hits          82274    82588   +314     
- Misses        44911    45049   +138     
- Partials       6048     6093    +45     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.71% <ø> (+<0.01%) ⬆️
java-21 61.61% <ø> (-0.02%) ⬇️
skip-bytebuffers-false 61.73% <ø> (-0.01%) ⬇️
skip-bytebuffers-true 61.59% <ø> (+33.86%) ⬆️
temurin 61.75% <ø> (+<0.01%) ⬆️
unittests 61.75% <ø> (+<0.01%) ⬆️
unittests1 46.95% <ø> (+0.06%) ⬆️
unittests2 27.67% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 merged commit 5beab96 into apache:master Mar 8, 2024
21 checks passed
@xiangfu0 xiangfu0 deleted the move-wildfly-openssl-dep branch March 8, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants