add unit test for ServerChannels #12616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullis
force-pushed
the
sean/ServerChannelsTest-add
branch
2 times, most recently
from
fb3d19d
to
4e7e4f4
Compare
sullis
force-pushed
the
sean/ServerChannelsTest-add
branch
from
4e7e4f4
to
9f34a6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12616 +/- ##
============================================
+ Coverage 61.75% 61.80% +0.05%
+ Complexity 207 198 -9
============================================
Files 2436 2452 +16
Lines 133233 133791 +558
Branches 20636 20749 +113
============================================
+ Hits 82274 82691 +417
- Misses 44911 44988 +77
- Partials 6048 6112 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ready for review |
Jackie-Jiang
approved these changes
Mar 11, 2024
| } | ||
|
|
||
| @BeforeClass | ||
| public void beforeClass() |
There was a problem hiding this comment.
(convention) We usually name it setUp()
| } | ||
|
|
||
| @AfterClass | ||
| public void afterClass() |
There was a problem hiding this comment.
(convention) We usually name it tearDown()
| } | ||
|
|
||
| @Test(dataProvider = "parameters") | ||
| public void testConnect(final boolean nativeTransportEnabled) |
There was a problem hiding this comment.
(convention) We don't usually put final for local variables
| throws Exception { | ||
| PinotMetricUtils.init(new PinotConfiguration()); | ||
| PinotMetricsRegistry registry = PinotMetricUtils.getPinotMetricsRegistry(); | ||
| BrokerMetrics brokerMetrics = new BrokerMetrics(registry); |
There was a problem hiding this comment.
We can mock the BrokerMetrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.