Speed up dev build. #14210
Open
Speed up dev build. #14210
+53
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14210 +/- ##
============================================
- Coverage 61.75% 55.45% -6.30%
- Complexity 207 797 +590
============================================
Files 2436 2074 -362
Lines 133233 109458 -23775
Branches 20636 17332 -3304
============================================
- Hits 82274 60701 -21573
+ Misses 44911 43914 -997
+ Partials 6048 4843 -1205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
reviewed
Oct 11, 2024
vrajat
reviewed
Oct 15, 2024
# Conflicts: # pom.xml
…es against /dist/webapp/js/main.js. If source files are older than mina.js npm build is skipped.
gortiz
reviewed
Oct 18, 2024
gortiz
reviewed
Oct 18, 2024
gortiz
reviewed
Oct 18, 2024
gortiz
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up developer build (one with pinot-fastdev profile enabled) by skipping compression and e.g. npm validation.
Following build command on my desktop :
mvn -DskipTests=true --also-make --projects pinot-distribution package -P'pinot-fastdev,bin-dist' -T1Ctakes:
in master branch - 3 minutes
in this branch - 2 minutes.
It looks possible to shave another 30 seconds by disabling compression in shade plugin but that'd require changing plugin code.