Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up dev build. #14210

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+53 −1
Open

Speed up dev build. #14210

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
badd7b0
Speedup dev build.
bziobrowski Oct 11, 2024
58b6b80
Merge remote-tracking branch 'origin/master' into speedup_build
bziobrowski Oct 15, 2024
d7b7ae2
Merge remote-tracking branch 'origin/master' into speedup_build
bziobrowski Oct 16, 2024
5f065cb
Reverted npm build changes and added up-to-date check of frontend fil…
bziobrowski Oct 16, 2024
3ddcbc2
Push to trigger build.
bziobrowski Oct 16, 2024
30f6d39
Removed obsolete properties and comments.
bziobrowski Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ more information on how to contribute to Apache Pinot.
Normal Pinot builds are done using the `mvn clean install` command.
However this command can take a long time to run.
For faster builds it is recommended to use `mvn verify -Ppinot-fastdev`, which disables some plugins that are not
actually needed for development.
actually needed for development and disables artifact compression.

## Building Pinot
More detailed instructions can be found at [Quick Demo](https://docs.pinot.apache.org/basics/getting-started/quick-start) section in the documentation.
Expand Down
39 changes: 38 additions & 1 deletion pinot-controller/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<properties>
<pinot.root>${basedir}/..</pinot.root>
<npm.script>build-ci</npm.script>
<npm.command>ci</npm.command>
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -121,7 +122,7 @@
</configuration>
</execution>
<execution>
<id>npm ci</id>
<id>npm ci</id><!-- npm ci removes node_modules! -->
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
<goals>
<goal>npm</goal>
</goals>
Expand Down Expand Up @@ -166,5 +167,41 @@
<npm.script>build</npm.script>
</properties>
</profile>
<profile>
<id>pinot-fastdev</id>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>3.6.0</version>
<executions>
<execution>
<id>check-frontend-up-to-date</id>
<phase>process-sources</phase>
<goals>
<goal>uptodate-property</goal>
</goals>
<configuration>
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
<fileSet>
<directory>${project.basedir}/src/main/resources/app</directory>
<outputDirectory>${project.basedir}/src/main/resources/dist/webapp/js</outputDirectory>
<includes>
<include>**/*</include>
</includes>
<mapper>
<type>merge</type>
<to>main.js</to>
</mapper>
</fileSet>
<name>skip.npm</name>
<value>true</value>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
4 changes: 4 additions & 0 deletions pinot-distribution/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@
<descriptor>${pinot.root}/pinot-distribution/pinot-source-assembly.xml</descriptor>
</descriptors>
<appendAssemblyId>false</appendAssemblyId>
<archiverConfig>
<compress>${archiver.compress}</compress>
</archiverConfig>
<recompressZippedFiles>${archiver.recompressZippedFiles}</recompressZippedFiles>
</configuration>
</execution>
</executions>
Expand Down
4 changes: 4 additions & 0 deletions pinot-plugins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
<descriptorRefs>
<descriptorRef>pinot-plugin</descriptorRef>
</descriptorRefs>
<archiverConfig>
<compress>${archiver.compress}</compress>
</archiverConfig>
<recompressZippedFiles>${archiver.recompressZippedFiles}</recompressZippedFiles>
</configuration>
</execution>
</executions>
Expand Down
4 changes: 4 additions & 0 deletions pinot-tools/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,10 @@
</manifest>
</archive>
<finalName>pinot-tool-launcher</finalName>
<archiverConfig>
<compress>${archiver.compress}</compress>
</archiverConfig>
<recompressZippedFiles>${archiver.recompressZippedFiles}</recompressZippedFiles>
</configuration>
<phase>package</phase>
<goals>
Expand Down
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,8 @@
<h2.version>2.3.232</h2.version>
<jnr-posix.version>3.1.20</jnr-posix.version>
<scalatest.version>3.2.19</scalatest.version>
<archiver.compress>true</archiver.compress>
<archiver.recompressZippedFiles>true</archiver.recompressZippedFiles>
</properties>

<profiles>
Expand All @@ -294,6 +296,9 @@
<rat.skip>true</rat.skip>
<spotless.check.skip>true</spotless.check.skip>
<shade.phase.prop>none</shade.phase.prop>
<archiver.compress>false</archiver.compress>
<archiver.recompressZippedFiles>false</archiver.recompressZippedFiles>
<npm.command>install --no-audit</npm.command>
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
</properties>
</profile>
<!--build profile for linux-aarch64. We exclude certain tests as they use runtime JNI bindings not supported for linux-aarch64-->
Expand Down
Loading