Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up dev build. #14210

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ more information on how to contribute to Apache Pinot.
Normal Pinot builds are done using the `mvn clean install` command.
However this command can take a long time to run.
For faster builds it is recommended to use `mvn verify -Ppinot-fastdev`, which disables some plugins that are not
actually needed for development.
actually needed for development and disables artifact compression.

## Building Pinot
More detailed instructions can be found at [Quick Demo](https://docs.pinot.apache.org/basics/getting-started/quick-start) section in the documentation.
Expand Down
11 changes: 9 additions & 2 deletions pinot-controller/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<properties>
<pinot.root>${basedir}/..</pinot.root>
<npm.script>build-ci</npm.script>
<npm.command>ci</npm.command>
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -121,13 +122,13 @@
</configuration>
</execution>
<execution>
<id>npm ci</id>
<id>npm ci</id><!-- npm ci removes node_modules! -->
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
bziobrowski marked this conversation as resolved.
Show resolved Hide resolved
<goals>
<goal>npm</goal>
</goals>
<phase>generate-resources</phase>
<configuration>
<arguments>ci</arguments>
<arguments>${npm.command}</arguments>
</configuration>
</execution>
<execution>
Expand Down Expand Up @@ -166,5 +167,11 @@
<npm.script>build</npm.script>
</properties>
</profile>
<profile>
<id>pinot-fastdev</id>
<properties>
<npm.command>install --no-audit</npm.command>
</properties>
</profile>
</profiles>
</project>
Loading
Loading