Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE - triggering tests] Egalpin/refactor broker request handle request #14213

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

egalpin
Copy link
Member

@egalpin egalpin commented Oct 12, 2024

Instructions:

  1. The PR has to be tagged with at least one of the following labels (*):
    1. feature
    2. bugfix
    3. performance
    4. ui
    5. backward-incompat
    6. release-notes (**)
  2. Remove these instructions before publishing the PR.

(*) Other labels to consider:

  • testing
  • dependencies
  • docker
  • kubernetes
  • observability
  • security
  • code-style
  • extension-point
  • refactor
  • cleanup

(**) Use release-notes label for scenarios like:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed

…tting QueryOptionKey.SERVER_RETURN_FINAL_RESULT
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 73.45133% with 60 lines in your changes missing coverage. Please review.

Project coverage is 55.44%. Comparing base (59551e4) to head (0b53a3d).
Report is 1196 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pinot/core/transport/AsyncQueryResponse.java 69.56% 17 Missing and 4 partials ⚠️
...rg/apache/pinot/core/transport/ServerChannels.java 47.05% 5 Missing and 4 partials ⚠️
...a/org/apache/pinot/core/transport/QueryRouter.java 80.55% 5 Missing and 2 partials ⚠️
...rg/apache/pinot/core/transport/ServerInstance.java 33.33% 4 Missing ⚠️
...e/pinot/core/query/reduce/BrokerReduceService.java 86.95% 2 Missing and 1 partial ⚠️
...e/pinot/core/query/request/ServerQueryRequest.java 66.66% 3 Missing ⚠️
...inot/core/transport/ServerQueryRoutingContext.java 76.92% 3 Missing ⚠️
...ot/core/query/reduce/ExecutionStatsAggregator.java 66.66% 1 Missing and 1 partial ⚠️
...che/pinot/core/query/scheduler/QueryScheduler.java 50.00% 2 Missing ⚠️
...he/pinot/core/transport/ServerRoutingInstance.java 80.00% 2 Missing ⚠️
... and 4 more

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (0b53a3d). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (59551e4) HEAD (0b53a3d)
integration2 3 1
temurin 12 10
skip-bytebuffers-true 3 2
skip-bytebuffers-false 7 5
unittests 5 3
java-11 5 3
unittests2 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14213      +/-   ##
============================================
- Coverage     61.75%   55.44%   -6.31%     
- Complexity      207      796     +589     
============================================
  Files          2436     2075     -361     
  Lines        133233   109489   -23744     
  Branches      20636    17338    -3298     
============================================
- Hits          82274    60704   -21570     
+ Misses        44911    43943     -968     
+ Partials       6048     4842    -1206     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 55.42% <73.45%> (-6.29%) ⬇️
java-21 55.29% <73.45%> (-6.34%) ⬇️
skip-bytebuffers-false 55.43% <73.45%> (-6.32%) ⬇️
skip-bytebuffers-true 55.27% <73.45%> (+27.54%) ⬆️
temurin 55.44% <73.45%> (-6.31%) ⬇️
unittests 55.44% <73.45%> (-6.31%) ⬇️
unittests1 55.44% <73.45%> (+8.54%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egalpin egalpin force-pushed the egalpin/refactor-broker-request-handle-request branch 3 times, most recently from 47a6d47 to e6d7944 Compare October 16, 2024 19:23
@egalpin egalpin force-pushed the egalpin/refactor-broker-request-handle-request branch from e6d7944 to 0b53a3d Compare October 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants