Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Map data type in UI #14245

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

esakkiraj
Copy link
Contributor

@esakkiraj esakkiraj commented Oct 16, 2024

Support for Map data types in UI. Handled in both Schema page and Query page.

Related Backend PR: #13906

Screenshots:

Screenshot 2024-10-16 at 2 34 40 PM -------- Screenshot 2024-10-16 at 2 35 25 PM

@jayeshchoudhary
Copy link
Contributor

@esakkiraj what about other places where we show schema details
like table details page. are we using the same component to render schema table?

image

@jayeshchoudhary
Copy link
Contributor

what will happen if the data is overflowing the cell?
image

@esakkiraj
Copy link
Contributor Author

@esakkiraj what about other places where we show schema details like table details page. are we using the same component to render schema table?

image

@jayeshchoudhary Yes it is handled.

Screenshot 2024-10-16 at 7 20 10 PM

@esakkiraj
Copy link
Contributor Author

what will happen if the data is overflowing the cell? image

@jayeshchoudhary Yeah good catch. @raghavyadav01 Any thoughts on this what should be done ? Should we trim the data if its beyond certain limit (Eg: 100 chars) and append "...".

@raghavyadav01
Copy link
Contributor

What is the current behavior for JSON column types? We should keep the same.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.45%. Comparing base (59551e4) to head (698f7ea).
Report is 1203 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (698f7ea). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (59551e4) HEAD (698f7ea)
integration2 3 2
temurin 12 11
skip-bytebuffers-false 7 5
unittests 5 3
java-11 5 3
unittests2 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14245      +/-   ##
============================================
- Coverage     61.75%   55.45%   -6.30%     
- Complexity      207      797     +590     
============================================
  Files          2436     2074     -362     
  Lines        133233   109458   -23775     
  Branches      20636    17332    -3304     
============================================
- Hits          82274    60702   -21572     
+ Misses        44911    43914     -997     
+ Partials       6048     4842    -1206     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 55.43% <ø> (-6.28%) ⬇️
java-21 55.28% <ø> (-6.35%) ⬇️
skip-bytebuffers-false 55.45% <ø> (-6.30%) ⬇️
skip-bytebuffers-true 55.24% <ø> (+27.51%) ⬆️
temurin 55.45% <ø> (-6.30%) ⬇️
unittests 55.45% <ø> (-6.30%) ⬇️
unittests1 55.45% <ø> (+8.56%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 added ui UI related issue feature labels Oct 17, 2024
@xiangfu0 xiangfu0 merged commit 7129392 into apache:master Oct 19, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants