-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Map data type in UI #14245
Conversation
@esakkiraj what about other places where we show schema details |
@jayeshchoudhary Yes it is handled. |
@jayeshchoudhary Yeah good catch. @raghavyadav01 Any thoughts on this what should be done ? Should we trim the data if its beyond certain limit (Eg: 100 chars) and append "...". |
What is the current behavior for JSON column types? We should keep the same. |
f16a90a
to
9f18206
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14245 +/- ##
============================================
- Coverage 61.75% 55.45% -6.30%
- Complexity 207 797 +590
============================================
Files 2436 2074 -362
Lines 133233 109458 -23775
Branches 20636 17332 -3304
============================================
- Hits 82274 60702 -21572
+ Misses 44911 43914 -997
+ Partials 6048 4842 -1206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7b045c5
to
262f200
Compare
262f200
to
698f7ea
Compare
Support for Map data types in UI. Handled in both Schema page and Query page.
Related Backend PR: #13906
Screenshots:
--------