Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect ledgerID and entryID logged when producer receives unexpected ack #1162

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions integration-tests/conf/standalone.conf
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ maxUnackedMessagesPerConsumer=50000
# Set maxMessageSize to 1MB rather than the default value 5MB for testing
maxMessageSize=1048576

brokerDeduplicationEnabled=true

### --- Authentication --- ###

# Enable TLS
Expand Down
12 changes: 8 additions & 4 deletions pulsar/producer_partition.go
Original file line number Diff line number Diff line change
Expand Up @@ -1274,14 +1274,18 @@ func (p *partitionProducer) ReceivedSendReceipt(response *pb.CommandSendReceipt)

if pi.sequenceID < response.GetSequenceId() {
// Force connection closing so that messages can be re-transmitted in a new connection
p.log.Warnf("Received ack for %v on sequenceId %v - expected: %v, local < remote, closing connection",
response.GetMessageId(), response.GetSequenceId(), pi.sequenceID)
p.log.Warnf("Received ack for ledgerId:%d entryId:%d on sequenceId %v - expected: %v, local < remote, "+
"closing connection",
int64(*response.GetMessageId().LedgerId), int64(*response.GetMessageId().EntryId), response.GetSequenceId(),
pi.sequenceID)
p._getConn().Close()
return
} else if pi.sequenceID > response.GetSequenceId() {
// Ignoring the ack since it's referring to a message that has already timed out.
p.log.Warnf("Received ack for %v on sequenceId %v - expected: %v, local > remote, ignore it",
response.GetMessageId(), response.GetSequenceId(), pi.sequenceID)
p.log.Warnf("Received ack for ledgerId:%d entryId:%d on sequenceId %v - expected: %v, local > remote, "+
"ignore it",
int64(*response.GetMessageId().LedgerId), int64(*response.GetMessageId().EntryId), response.GetSequenceId(),
pi.sequenceID)
return
} else {
// The ack was indeed for the expected item in the queue, we can remove it and trigger the callback
Expand Down
30 changes: 30 additions & 0 deletions pulsar/producer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2385,6 +2385,36 @@ func TestSendConcurrently(t *testing.T) {
wg.Wait()
}

func TestProducerSendDuplicatedMessages(t *testing.T) {
client, err := NewClient(ClientOptions{
URL: lookupURL,
})
assert.NoError(t, err)
defer client.Close()
testProducer, err := client.CreateProducer(ProducerOptions{
Topic: newTopicName(),
})

assert.NoError(t, err)
assert.NotNil(t, testProducer)
_, err = testProducer.Send(context.Background(), &ProducerMessage{
Payload: make([]byte, 1024),
})
assert.NoError(t, err)
for i := 0; i < 3; i++ {
var seqID int64
msgID, err := testProducer.Send(context.Background(), &ProducerMessage{
Payload: make([]byte, 1024),
SequenceID: &seqID,
})
assert.NoError(t, err)
assert.NotNil(t, msgID)
assert.Equal(t, int64(-1), msgID.LedgerID())
assert.Equal(t, int64(-1), msgID.EntryID())
}
testProducer.Close()
}

type pendingQueueWrapper struct {
pendingQueue internal.BlockingQueue
writtenBuffers *[]internal.Buffer
Expand Down
Loading