fix: failed to update opsrequest (#4951) (#4965)

controllers/apps/operations/reconfigure_util.go

@@ -164,7 +164,7 @@ func updateOpsLabelWithReconfigure(obj *appsv1alpha1.OpsRequest, params []core.P
 				return
 			}
 			maxLabelCount--
-			obj.Labels[key] = cast.ToString(val)
+			obj.Labels[key] = core.FromValueToString(val)
 		}
 	}
 	updateAnnotation := func(keyFile string, param map[string]interface{}) {

internal/configuration/core/config_util.go

@@ -21,7 +21,9 @@ package core
 
 import (
 	"context"
+	"regexp"
 
+	"github.com/spf13/cast"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 
@@ -34,6 +36,18 @@ type ParamPairs struct {
 	UpdatedParams map[string]interface{}
 }
 
+const pattern = `^[a-z0-9A-Z]([a-zA-Z0-9\.\-\_]*[a-zA-Z0-9])?$`
+
+var regxPattern = regexp.MustCompile(pattern)
+
+func FromValueToString(val interface{}) string {
+	str := cast.ToString(val)
+	if regxPattern.MatchString(str) {
+		return str
+	}
+	return ""
+}
+
 // MergeUpdatedConfig replaces the file content of the changed key.
 // baseMap is the original configuration file,
 // updatedMap is the updated configuration file

internal/configuration/core/config_util_test.go

@@ -246,3 +246,57 @@ test=test
 		})
 	}
 }
+
+func TestFromValueToString(t *testing.T) {
+	type args struct {
+		val interface{}
+	}
+	tests := []struct {
+		name string
+		args args
+		want string
+	}{{
+		name: "test",
+		args: args{
+			val: "testTest",
+		},
+		want: "testTest",
+	}, {
+		name: "test",
+		args: args{
+			val: "",
+		},
+		want: "",
+	}, {
+		name: "test",
+		args: args{
+			val: nil,
+		},
+		want: "",
+	}, {
+		name: "test",
+		args: args{
+			val: "/abdet/sds",
+		},
+		want: "",
+	}, {
+		name: "test",
+		args: args{
+			val: "abdet/sds-",
+		},
+		want: "",
+	}, {
+		name: "test",
+		args: args{
+			val: "abcdASls-sda_102.382",
+		},
+		want: "abcdASls-sda_102.382",
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := FromValueToString(tt.args.val); got != tt.want {
+				t.Errorf("FromValueToString() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}