fix stateful rsm block in updating phase

apecloud · Sep 14, 2023 · 259cef8 · 259cef8
1 parent 13be616
commit 259cef8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/internal/controller/rsm/transformer_member_reconfiguration.go b/internal/controller/rsm/transformer_member_reconfiguration.go
@@ -54,6 +54,10 @@ func (t *MemberReconfigurationTransformer) Transform(ctx graph.TransformContext,
 	}
 	rsm := transCtx.rsm
 
+	if len(rsm.Spec.Roles) == 0 || rsm.Spec.RoleProbe == nil {
+		return nil
+	}
+
 	// handle cluster initialization
 	// set initReplicas at creation
 	if rsm.Status.InitReplicas == 0 {

diff --git a/internal/controller/rsm/transformer_member_reconfiguration_test.go b/internal/controller/rsm/transformer_member_reconfiguration_test.go
@@ -125,7 +125,7 @@ var _ = Describe("member reconfiguration transformer test.", func() {
 		transformer = &MemberReconfigurationTransformer{}
 	})
 
-	Context("cluster initialization", func() {
+	Context("roleful cluster initialization", func() {
 		It("should initialize well", func() {
 			By("initialReplicas=0")
 			Expect(transformer.Transform(transCtx, dag)).Should(Succeed())
@@ -149,6 +149,16 @@ var _ = Describe("member reconfiguration transformer test.", func() {
 		})
 	})
 
+	Context("stateful cluster initialization", func() {
+		It("should work well", func() {
+			By("set spec.roles to nil")
+			rsm.Spec.Roles = nil
+			Expect(transformer.Transform(transCtx, dag)).Should(Succeed())
+			Expect(rsm.Status.InitReplicas).Should(BeEquivalentTo(0))
+			Expect(rsm.Status.ReadyInitReplicas).Should(BeEquivalentTo(0))
+		})
+	})
+
 	Context("scale-out", func() {
 		It("should work well", func() {
 			By("make rsm ready for scale-out")