fix

apecloud · Nov 18, 2024 · 7a7795a · 7a7795a
1 parent 57a542a
commit 7a7795a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 62 deletions.
diff --git a/controllers/dataprotection/backupschedule_controller_test.go b/controllers/dataprotection/backupschedule_controller_test.go
@@ -27,7 +27,6 @@ import (
 	batchv1 "k8s.io/api/batch/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
-	"github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1"
 	dpv1alpha1 "github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1"
 	"github.com/apecloud/kubeblocks/pkg/constant"
 	dpbackup "github.com/apecloud/kubeblocks/pkg/dataprotection/backup"
@@ -217,7 +216,7 @@ var _ = Describe("Backup Schedule Controller", func() {
 					g.Expect(fetched.Status.Phase).NotTo(Equal(dpv1alpha1.BackupSchedulePhaseAvailable))
 				})).Should(Succeed())
 				By("set valid parameters")
-				Expect(testapps.ChangeObj(&testCtx, backupSchedule, func(bs *v1alpha1.BackupSchedule) {
+				Expect(testapps.ChangeObj(&testCtx, backupSchedule, func(bs *dpv1alpha1.BackupSchedule) {
 					backupSchedule.Spec.Schedules[1].Parameters = testdp.TestParameters
 				})).Should(Succeed())
 				By("checking backupSchedule status, should be available")

diff --git a/docs/developer_docs/api-reference/backup.md b/docs/developer_docs/api-reference/backup.md
@@ -338,14 +338,12 @@ string
 <td>
 <code>parameters</code><br/>
 <em>
-<a href="#dataprotection.kubeblocks.io/v1alpha1.ParameterPair">
-[]ParameterPair
-</a>
+map[string]string
 </em>
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies a list of pairs representing parameters and their corresponding values.
+<p>Specifies parameters and their corresponding values.
 Parameters match the schema specified in the <code>actionset.spec.parametersSchema</code></p>
 </td>
 </tr>
@@ -1009,14 +1007,12 @@ int32
 <td>
 <code>parameters</code><br/>
 <em>
-<a href="#dataprotection.kubeblocks.io/v1alpha1.ParameterPair">
-[]ParameterPair
-</a>
+map[string]string
 </em>
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies a list of pairs representing parameters and their corresponding values.
+<p>Specifies parameters and their corresponding values.
 Parameters match the schema specified in the <code>actionset.spec.parametersSchema</code></p>
 </td>
 </tr>
@@ -3211,14 +3207,12 @@ string
 <td>
 <code>parameters</code><br/>
 <em>
-<a href="#dataprotection.kubeblocks.io/v1alpha1.ParameterPair">
-[]ParameterPair
-</a>
+map[string]string
 </em>
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies a list of pairs representing parameters and their corresponding values.
+<p>Specifies parameters and their corresponding values.
 Parameters match the schema specified in the <code>actionset.spec.parametersSchema</code></p>
 </td>
 </tr>
@@ -4405,45 +4399,6 @@ The default value is empty.</p>
 </tr>
 </tbody>
 </table>
-<h3 id="dataprotection.kubeblocks.io/v1alpha1.ParameterPair">ParameterPair
-</h3>
-<p>
-(<em>Appears on:</em><a href="#dataprotection.kubeblocks.io/v1alpha1.BackupSpec">BackupSpec</a>, <a href="#dataprotection.kubeblocks.io/v1alpha1.RestoreSpec">RestoreSpec</a>, <a href="#dataprotection.kubeblocks.io/v1alpha1.SchedulePolicy">SchedulePolicy</a>)
-</p>
-<div>
-</div>
-<table>
-<thead>
-<tr>
-<th>Field</th>
-<th>Description</th>
-</tr>
-</thead>
-<tbody>
-<tr>
-<td>
-<code>name</code><br/>
-<em>
-string
-</em>
-</td>
-<td>
-<p>Represents the name of the parameter.</p>
-</td>
-</tr>
-<tr>
-<td>
-<code>value</code><br/>
-<em>
-string
-</em>
-</td>
-<td>
-<p>Represents the parameter values.</p>
-</td>
-</tr>
-</tbody>
-</table>
 <h3 id="dataprotection.kubeblocks.io/v1alpha1.ParametersSchema">ParametersSchema
 </h3>
 <p>
@@ -5236,14 +5191,12 @@ int32
 <td>
 <code>parameters</code><br/>
 <em>
-<a href="#dataprotection.kubeblocks.io/v1alpha1.ParameterPair">
-[]ParameterPair
-</a>
+map[string]string
 </em>
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies a list of pairs representing parameters and their corresponding values.
+<p>Specifies parameters and their corresponding values.
 Parameters match the schema specified in the <code>actionset.spec.parametersSchema</code></p>
 </td>
 </tr>
@@ -5732,7 +5685,7 @@ string
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies the name of the schedule.</p>
+<p>Specifies the name of the schedule. Names cannot be duplicated</p>
 </td>
 </tr>
 <tr>
@@ -5787,14 +5740,12 @@ Sample duration format:</p>
 <td>
 <code>parameters</code><br/>
 <em>
-<a href="#dataprotection.kubeblocks.io/v1alpha1.ParameterPair">
-[]ParameterPair
-</a>
+map[string]string
 </em>
 </td>
 <td>
 <em>(Optional)</em>
-<p>Specifies a list of pairs representing parameters and their corresponding values.
+<p>Specifies parameters and their corresponding values.
 Parameters match the schema specified in the <code>actionset.spec.parametersSchema</code></p>
 </td>
 </tr>