Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] kb cluster sidecar containers have issues if has ResourceQuota API settings #2738

Closed
nashtsai opened this issue Apr 19, 2023 · 4 comments · Fixed by #3997
Closed

[BUG] kb cluster sidecar containers have issues if has ResourceQuota API settings #2738

nashtsai opened this issue Apr 19, 2023 · 4 comments · Fixed by #3997
Assignees
Labels
bug kind/bug Something isn't working triage
Milestone

Comments

@nashtsai
Copy link
Contributor

nashtsai commented Apr 19, 2023

Describe the bug
kb cluster sidecar containers have issues if has ResourceQuota API settings.

To Reproduce

apiVersion: v1
kind: ResourceQuota
metadata:
  name: quota
spec:
  hard:
    limits.cpu: "16"
    limits.ephemeral-storage: 100Gi
    limits.memory: 64Gi
    requests.storage: 100Gi

Expected behavior
(TBD, personally I would expect cluster controller detect the installing cluster NS reside ResourceQuota object, and has no LimitRange specifying default limits should report a "Warning" event with message that provides help to check appropriate-ness of ResourceQuota and LimitRange settings.)

Screenshots
img_v2_ea42a439-81f4-44e9-a01f-116047debdbg

@nashtsai nashtsai added the kind/bug Something isn't working label Apr 19, 2023
@nashtsai nashtsai added this to the Release 0.5.0 milestone Apr 19, 2023
@nashtsai
Copy link
Contributor Author

@fireworm2002 @nayutah we need to discuss expect behavior.

@nashtsai
Copy link
Contributor Author

nashtsai commented Apr 20, 2023

ResourceQuota API should use with LimitRange API with default container settings.

apiVersion: v1
kind: LimitRange
metadata:
  name: range-{{ .Release.Namespace }}
  namespace: {{ .Release.Namespace }}
spec:
  limits:
  - default: # this section defines default limits
      cpu: 50m
      memory: 64Mi
    type: Container

@nashtsai
Copy link
Contributor Author

@fireworm2002 @nayutah do check this bug's expect.

@nashtsai
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug kind/bug Something isn't working triage
Projects
None yet
5 participants