Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addon controller adds support for checking if an addon is used by a cluster before deleting or disabling it.(#6434) #7170

Closed
wants to merge 8 commits into from

Conversation

skyrise-l
Copy link
Contributor

@skyrise-l skyrise-l commented Apr 25, 2024

fix #6434 : addon controller adds support for checking if an addon is used by a cluster before deleting or disabling it."

刘文豪 added 2 commits April 24, 2024 10:59
…y a cluster before deleting or disabling it.(#6434)
…addon is used by a cluster before deleting or disabling it.(#6434)
@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


刘文豪 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Apr 25, 2024
@skyrise-l skyrise-l changed the title Support/kb add cluster check fix: addon controller adds support for checking if an addon is used by a cluster before deleting or disabling it.(#6434) Apr 25, 2024
controllers/extensions/addon_controller_stages.go Outdated Show resolved Hide resolved
cmd/manager/main.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 64.86%. Comparing base (45dafd9) to head (ea423f8).
Report is 15 commits behind head on main.

Files Patch % Lines
controllers/extensions/addon_controller_stages.go 68.75% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7170      +/-   ##
==========================================
+ Coverage   64.81%   64.86%   +0.05%     
==========================================
  Files         337      337              
  Lines       41828    41860      +32     
==========================================
+ Hits        27110    27152      +42     
+ Misses      12358    12348      -10     
  Partials     2360     2360              
Flag Coverage Δ
unittests 64.86% <68.75%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skyrise-l skyrise-l requested a review from weicao as a code owner May 7, 2024 02:24
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 7, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label May 8, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 8, 2024
@skyrise-l skyrise-l force-pushed the support/kb-add-cluster-check branch from d135165 to c314b27 Compare May 8, 2024 03:43
@github-actions github-actions bot removed the size/L Denotes a PR that changes 100-499 lines. label May 8, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label May 8, 2024
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label May 8, 2024
@skyrise-l skyrise-l force-pushed the support/kb-add-cluster-check branch from c314b27 to d135165 Compare May 8, 2024 03:48
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels May 8, 2024
@skyrise-l skyrise-l force-pushed the support/kb-add-cluster-check branch from d135165 to bb6c864 Compare May 8, 2024 03:56
@skyrise-l skyrise-l force-pushed the support/kb-add-cluster-check branch from bb6c864 to ea423f8 Compare May 8, 2024 04:07
@skyrise-l skyrise-l self-assigned this May 8, 2024
@skyrise-l skyrise-l closed this May 8, 2024
@skyrise-l skyrise-l deleted the support/kb-add-cluster-check branch May 8, 2024 05:30
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] do not allow to disable addon if any clusters are using it
5 participants