Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add addon checks to fix null pointer error bug in Kubernetes versions prior to 1.25. (#7114) #7185

Closed
wants to merge 7 commits into from

Conversation

skyrise-l
Copy link
Contributor

@skyrise-l skyrise-l commented Apr 26, 2024

fix #7114 Add addon checks to fix null pointer error bug in Kubernetes versions prior to 1.25.
XValidation was introduced as an alpha feature in Kubernetes v1.23 and requires additional enablement. It became more stable after Kubernetes 1.25. Users encountered this error in a Kubernetes 1.23 environment.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


skyrise-l seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 26, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 64.89%. Comparing base (2280b96) to head (3293b50).
Report is 23 commits behind head on main.

Files Patch % Lines
controllers/extensions/addon_controller_stages.go 42.85% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7185      +/-   ##
==========================================
- Coverage   64.89%   64.89%   -0.01%     
==========================================
  Files         337      337              
  Lines       41759    41773      +14     
==========================================
+ Hits        27098    27107       +9     
- Misses      12305    12313       +8     
+ Partials     2356     2353       -3     
Flag Coverage Δ
unittests 64.89% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label May 6, 2024
@skyrise-l skyrise-l requested a review from weicao as a code owner May 6, 2024 08:29
@apecloud-bot apecloud-bot removed the approved PR Approved Test label May 6, 2024
@ldming
Copy link
Collaborator

ldming commented May 7, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

skyrise-l seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@wangyelei
Copy link
Contributor

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label May 8, 2024
@skyrise-l skyrise-l self-assigned this May 8, 2024
@skyrise-l skyrise-l closed this May 8, 2024
@skyrise-l skyrise-l deleted the bugfix/addon-yaml-check branch May 8, 2024 05:03
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] null pointer error in addon.spec.helm.chartlocationurl
6 participants