Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve redis get role #7206

Merged
merged 20 commits into from
May 7, 2024
Merged

fix: improve redis get role #7206

merged 20 commits into from
May 7, 2024

Conversation

kizuna-lek
Copy link
Collaborator

fix: #5107

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Apr 29, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.88%. Comparing base (e305958) to head (a67a5a7).
Report is 27 commits behind head on main.

Files Patch % Lines
...g/controller/instanceset/pod_role_event_handler.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7206      +/-   ##
==========================================
- Coverage   64.99%   64.88%   -0.12%     
==========================================
  Files         337      337              
  Lines       41723    41728       +5     
==========================================
- Hits        27118    27075      -43     
- Misses      12247    12288      +41     
- Partials     2358     2365       +7     
Flag Coverage Δ
unittests 64.88% <83.33%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kizuna-lek kizuna-lek requested a review from weicao as a code owner April 30, 2024 09:53
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 6, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label May 7, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 7, 2024
@kizuna-lek kizuna-lek merged commit 25d2cf4 into main May 7, 2024
62 checks passed
@kizuna-lek kizuna-lek deleted the bugfix/modify-redis-getrole branch May 7, 2024 03:38
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 7, 2024
@kizuna-lek
Copy link
Collaborator Author

/cherry-pick release-0.9

Copy link

github-actions bot commented May 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8979311442

github-actions bot pushed a commit that referenced this pull request May 7, 2024
(cherry picked from commit 25d2cf4)
@xuriwuyun
Copy link
Contributor

/cherry-pick release-0.8

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/9203415680

github-actions bot pushed a commit that referenced this pull request May 23, 2024
(cherry picked from commit 25d2cf4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Data lost when inject network delay fault to Redis cluster
4 participants