[BUG] redis cluster mode sentinel is not supported, despite what the help screen says.

[MarkKharitonov]

Describe the bug

According to the help screen, the supported modes include sentinel:

mark@L-R910LPKW:~$ kbcli cluster create redis redis -h | grep -A2 mode | head -2
    --mode='replication':
        Cluster topology mode. Legal values [standalone, replication, cluster, sentinel, replication-twemproxy].
mark@L-R910LPKW:~$

But trying to create a cluster in this mode produces invalid cluster:

mark@L-R910LPKW:~$ kbcli cluster create redis redis --mode sentinel
Info: --version is not specified, redis-7.2.4 is applied by default.
Cluster redis created
mark@L-R910LPKW:~$ k get cluster redis -o yaml | yq .status
conditions:
  - lastTransitionTime: "2024-08-26T17:53:19Z"
    message: 'specified cluster topology not found: sentinel'
    reason: PreCheckFailed
    status: "False"
    type: ProvisioningStarted
mark@L-R910LPKW:~$

To Reproduce

Steps to reproduce the behavior:

1. kbcli cluster create redis redis --mode sentinel
2. kubectl get cluster redis -o jsonpath='{.status.conditions[].message}' && echo

Expected behavior

The sentinel mode is supported as claimed in the help screen.

Desktop (please complete the following information):

mark@L-R910LPKW:~$ helm ls -n system-d-kube-blocks | grep redis
kb-addon-redis                  system-d-kube-blocks    1               2024-08-26 03:53:05.174636299 +0000 UTC deployed        redis-0.9.0
7.2.4
mark@L-R910LPKW:~$ uname -a
Linux L-R910LPKW 5.15.153.1-microsoft-standard-WSL2 #1 SMP Fri Mar 29 23:14:13 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
mark@L-R910LPKW:~$

Additional information

Trying to use the cluster mode fails right away:

mark@L-R910LPKW:~$ kbcli cluster create redis redis --mode cluster
error: cannot find clusterDefinitionRef in cluster spec or componentDef in componentSpecs
mark@L-R910LPKW:~$

This is again contrary to the help screen.

[shanshanying]

Hi @MarkKharitonov ,

thanks for reporting the issue. What is the version of kbcli and KubeBlocks you are working with?
you can use

kbcli version

to get the versions.

[shanshanying]

@Y-Rookie could you please help on this issue.

[Y-Rookie]

Hello @MarkKharitonov, I have confirmed that we indeed do not support the topology mode=sentinel. This is a legacy bug in kbcli, and we will fix it in the next release version. Additionally, if you want to create a redis cluster with sentinel, you can directly use the topology mode=replication. The topology mode=replication will create a Redis server with one primary and onesecondary by default, along with a three-replicas redis sentinel.

[MarkKharitonov]

Sure, I installed kb just 2 days ago for the first time:

mark@L-R910LPKW:~$ kbcli version
Kubernetes: v1.28.3
KubeBlocks: 0.9.0
kbcli: 0.9.0
mark@L-R910LPKW:~$

[shanshanying]

This will be fixed in our next minor version release 0.9.1.

[shanshanying]

fixed in apecloud/kbcli#450