Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to specify k8s scheduling policy in cluster API #8081

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Sep 4, 2024

cherry picked from commit 1471969

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 70 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (c59de8c) to head (8a071c0).
Report is 5 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/scheduling/scheduling_utils.go 37.93% 47 Missing and 7 partials ⚠️
pkg/controller/component/synthesize_component.go 55.00% 7 Missing and 2 partials ⚠️
pkg/controller/component/component.go 40.00% 2 Missing and 1 partial ⚠️
pkg/controller/builder/builder_component.go 0.00% 2 Missing ⚠️
pkg/controller/plan/restore.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8081      +/-   ##
===============================================
+ Coverage        65.20%   65.23%   +0.02%     
===============================================
  Files              356      356              
  Lines            44731    44792      +61     
===============================================
+ Hits             29169    29221      +52     
- Misses           12979    12986       +7     
- Partials          2583     2585       +2     
Flag Coverage Δ
unittests 65.23% <44.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 4, 2024
@leon-inf
Copy link
Contributor Author

leon-inf commented Sep 5, 2024

/approve

@leon-inf leon-inf merged commit 3c1a1e3 into release-0.9 Sep 9, 2024
70 of 74 checks passed
@leon-inf leon-inf deleted the support/scheduling-policy branch September 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants