Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filter events to reconcile by CRD API version #8084

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Sep 4, 2024

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 46.55172% with 31 lines in your changes missing coverage. Please review.

Project coverage is 65.01%. Comparing base (c59de8c) to head (4429cf5).
Report is 55 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controllerutil/predicate.go 0.00% 27 Missing ⚠️
controllers/apps/component_controller.go 50.00% 1 Missing ⚠️
...llers/dataprotection/storageprovider_controller.go 0.00% 1 Missing ⚠️
...rollers/experimental/nodecountscaler_controller.go 0.00% 1 Missing ⚠️
controllers/workloads/instanceset_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8084      +/-   ##
===============================================
- Coverage        65.20%   65.01%   -0.20%     
===============================================
  Files              356      358       +2     
  Lines            44731    45436     +705     
===============================================
+ Hits             29169    29540     +371     
- Misses           12979    13272     +293     
- Partials          2583     2624      +41     
Flag Coverage Δ
unittests 65.01% <46.55%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the support/crd-api-version-filter branch from f8c93c5 to d6b1330 Compare September 4, 2024 08:17
@leon-inf leon-inf added this to the Release 0.9.2 milestone Sep 11, 2024
@github-actions github-actions bot modified the milestones: Release 0.9.2, Release 0.8.5 Oct 8, 2024
@leon-inf leon-inf force-pushed the support/crd-api-version-filter branch from ae5c901 to 4429cf5 Compare October 23, 2024 08:28
@leon-inf leon-inf marked this pull request as ready for review October 24, 2024 09:22
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 29, 2024
@leon-inf leon-inf merged commit 7799869 into release-0.9 Oct 31, 2024
38 checks passed
@leon-inf leon-inf deleted the support/crd-api-version-filter branch October 31, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants