feat: introduce the available probe and condition #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8212 +/- ##
==========================================
- Coverage 60.84% 60.81% -0.04%
==========================================
Files 350 351 +1
Lines 40571 40645 +74
==========================================
+ Hits 24686 24717 +31
- Misses 13639 13681 +42
- Partials 2246 2247 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
force-pushed
the
feature/available-probe-and-conditions
branch
from
7df4c0f
to
c7faf48
Compare
leon-inf
force-pushed
the
feature/available-probe-and-conditions
branch
from
c7faf48
to
173961c
Compare
github-actions
bot
added
size/XXL
zjx20
reviewed
Sep 28, 2024
| break | ||
| } | ||
| } | ||
| if idx >= 0 && h.condEqual(comp.Status.Conditions[idx], newCond) { |
There was a problem hiding this comment.
can use helpers functions from https://github.com/kubernetes/apimachinery/blob/master/pkg/api/meta/conditions.go .
| if latestEvent != nil { | ||
| r.logger.Info("send probe event periodically", "probe", latestEvent.Probe, | ||
| "code", latestEvent.Code, "output", outputPrefix(latestEvent.Output), "message", latestEvent.Message) | ||
| r.sendEvent(latestEvent) |
There was a problem hiding this comment.
Why send the last event twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.