Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preConditionDeadlineSeconds of the opsRequest is invalid when creating some opsRequests together #8220

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner September 27, 2024 08:16
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 39.24051% with 48 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (e0bd32a) to head (b4b9b46).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/ops_manager.go 54.34% 16 Missing and 5 partials ⚠️
apis/operations/v1alpha1/opsrequest_validation.go 0.00% 14 Missing ⚠️
pkg/operations/ops_util.go 31.57% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8220      +/-   ##
==========================================
+ Coverage   60.88%   61.72%   +0.84%     
==========================================
  Files         354      354              
  Lines       40874    41529     +655     
==========================================
+ Hits        24885    25633     +748     
+ Misses      13722    13643      -79     
+ Partials     2267     2253      -14     
Flag Coverage Δ
unittests 61.72% <39.24%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 30, 2024
@wangyelei wangyelei merged commit c65ed8c into main Oct 8, 2024
38 checks passed
@wangyelei wangyelei deleted the bugfix/fix_preconditionDeadlineSeconds branch October 8, 2024 01:39
@github-actions github-actions bot added this to the Release 0.8.5 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] preConditionDeadlineSeconds of the opsRequest is invalid when doing some opsRequests together
4 participants