Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom opsRequest supports to input parameters from cm and secret #8221

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested a review from a team as a code owner September 27, 2024 09:52
@wangyelei wangyelei marked this pull request as draft September 27, 2024 09:52
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 27, 2024
@wangyelei wangyelei linked an issue Sep 27, 2024 that may be closed by this pull request
@wangyelei wangyelei changed the title chore: opsDef supports to input parameters from cm and secret feat: opsDef supports to input parameters from cm and secret Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes missing coverage. Please review.

Project coverage is 62.13%. Comparing base (c65ed8c) to head (f307a71).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operations/custom.go 57.14% 17 Missing and 4 partials ⚠️
pkg/operations/ops_manager.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8221      +/-   ##
==========================================
+ Coverage   61.36%   62.13%   +0.77%     
==========================================
  Files         349      351       +2     
  Lines       40290    41081     +791     
==========================================
+ Hits        24722    25526     +804     
+ Misses      13338    13310      -28     
- Partials     2230     2245      +15     
Flag Coverage Δ
unittests 62.13% <55.76%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei marked this pull request as ready for review October 8, 2024 05:56
@wangyelei wangyelei force-pushed the feature/add_valuefrom_for_opsdef branch from e6a1127 to 3053f4b Compare October 8, 2024 05:57
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 9, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Oct 9, 2024
@wangyelei wangyelei changed the title feat: opsDef supports to input parameters from cm and secret feat: custom opsRequest supports to input parameters from cm and secret Oct 10, 2024
pkg/operations/custom.go Outdated Show resolved Hide resolved
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 10, 2024
@wangyelei wangyelei merged commit 7875448 into main Oct 10, 2024
35 checks passed
@wangyelei wangyelei deleted the feature/add_valuefrom_for_opsdef branch October 10, 2024 02:04
@github-actions github-actions bot added this to the Release 0.9.2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] opsDef supports to input parameters from cm and secret
4 participants