chore: lifecycle action support target pod role selector #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om and
wangyelei
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #8438 +/- ##
===============================================
+ Coverage 64.70% 64.89% +0.18%
===============================================
Files 358 358
Lines 45485 45500 +15
===============================================
+ Hits 29432 29525 +93
+ Misses 13416 13342 -74
+ Partials 2637 2633 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wangyelei
reviewed
Nov 11, 2024
| // this is hack for some special cases which need to run on the same node as the target pod | ||
| if action.TargetPodSelector == appsv1alpha1.RoleSelector && len(action.MatchingKey) > 0 { | ||
| jobObj.Spec.Template.Spec.NodeSelector = map[string]string{ | ||
| "kubernetes.io/hostname": tplPod.Spec.NodeName, |
There was a problem hiding this comment.
use corev1.LabelHostname
There was a problem hiding this comment.
use
corev1.LabelHostname
done
wangyelei
approved these changes
Nov 11, 2024
ldming
approved these changes
Nov 11, 2024
Y-Rookie
deleted the
support/lifecycle-action-support-targetpod-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.