Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize class reference and add storage constraint #3596

Merged
merged 7 commits into from
Jul 7, 2023
Merged

chore: optimize class reference and add storage constraint #3596

merged 7 commits into from
Jul 7, 2023

Conversation

iziang
Copy link
Contributor

@iziang iziang commented Jun 6, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iziang iziang force-pushed the support/class-optimization branch from d885035 to 177790a Compare June 6, 2023 14:58
@github-actions
Copy link

github-actions bot commented Jun 6, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@iziang
Copy link
Contributor Author

iziang commented Jun 6, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jun 6, 2023
@github-actions
@iziang has signed the CLA in #3596
be35c88
@iziang iziang force-pushed the support/class-optimization branch 3 times, most recently from 94638dc to 24695b9 Compare June 7, 2023 15:52
@iziang iziang linked an issue Jun 8, 2023 that may be closed by this pull request
[Improvement] use resource constraint instead of class #3554
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023 •
edited by codecov bot
Loading

Codecov Report

Patch coverage: 54.71% and project coverage change: -0.12 ⚠️

Comparison is base (46ab04e) 62.40% compared to head (9b90f44) 62.28%.

❗ Current head 9b90f44 differs from pull request most recent head 3083224. Consider uploading reports for the commit 3083224 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3596      +/-   ##
==========================================
- Coverage   62.40%   62.28%   -0.12%     
==========================================
  Files         244      244              
  Lines       31400    31573     +173     
==========================================
+ Hits        19594    19665      +71     
- Misses      10050    10150     +100     
- Partials     1756     1758       +2
Flag Coverage Δ
unittests 62.28% <54.71%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/apps/v1alpha1/opsrequest_types.go 85.14% <ø> (ø)
controllers/apps/cluster_controller.go 93.75% <ø> (-0.19%) ⬇️
internal/controller/component/component.go 42.55% <10.63%> (-6.40%) ⬇️
internal/class/class_utils.go 44.11% <46.15%> (+0.01%) ⬆️
controllers/apps/operations/vertical_scaling.go 83.58% <50.00%> (-1.27%) ⬇️
...apps/v1alpha1/componentresourceconstraint_types.go 81.03% <78.37%> (-5.33%) ⬇️
...is/apps/v1alpha1/componentclassdefinition_types.go 93.75% <87.50%> (+68.75%) ⬆️
internal/class/types.go 85.41% <92.00%> (-4.59%) ⬇️
controllers/apps/class_controller.go 70.68% <100.00%> (ø)
internal/controller/component/class_utils.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JashBook JashBook added the size/XXL Denotes a PR that changes 1000+ lines. label Jun 12, 2023
@iziang iziang linked an issue Jun 12, 2023 that may be closed by this pull request
[Features] resource constraints of cluster #3642
Closed
@ahjing99 ahjing99 linked an issue Jun 15, 2023 that may be closed by this pull request
[BUG]Mysql cluster status is ConditionsError after upgrade kubeblocks from 0.5 to 0.6 for can not find matching class #3770
Closed
@iziang iziang linked an issue Jun 18, 2023 that may be closed by this pull request
[BUG] create cluster with Halt termination policy , then delete cluster create a cluster with the same name failed #3773
Closed
@iziang iziang force-pushed the support/class-optimization branch 2 times, most recently from 3fb2495 to d42964d Compare June 18, 2023 05:40
@nashtsai
Copy link
Contributor

do check code coverage

@iziang iziang force-pushed the support/class-optimization branch from 15b0128 to 884f630 Compare June 23, 2023 14:03
@iziang iziang force-pushed the support/class-optimization branch from e5976b1 to 316f9fb Compare June 23, 2023 15:17
@iziang
Copy link
Contributor Author

iziang commented Jul 7, 2023

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 7, 2023
@iziang iziang merged commit 5603314 into main Jul 7, 2023
50 checks passed
@iziang iziang deleted the support/class-optimization branch July 7, 2023 08:19
@iziang iziang linked an issue Aug 3, 2023 that may be closed by this pull request
[BUG]More meaningful message should be returned when resource not meet requirement when create cluster #4211
Closed
@iziang iziang removed a link to an issue Aug 3, 2023
[BUG]More meaningful message should be returned when resource not meet requirement when create cluster #4211
Closed
1aal pushed a commit that referenced this pull request Aug 30, 2023
@iziang
chore: optimize class reference and add storage constraint (#3596)
0e1ab7a
ldming pushed a commit that referenced this pull request Nov 21, 2023
@iziang @ldming
chore: optimize class reference and add storage constraint (#3596)
2e94353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashtsai nashtsai nashtsai approved these changes

@ldming ldming ldming approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@dengshaojiang dengshaojiang Awaiting requested review from dengshaojiang

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
7 participants
@iziang @CLAassistant @codecov-commenter @nashtsai @ldming @apecloud-bot @JashBook