Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configmap mounted with subPath do not update when changed (#3870) #3883

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 79.10% and project coverage change: +0.12 🎉

Comparison is base (b4b54d8) 68.24% compared to head (54daf16) 68.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3883      +/-   ##
==========================================
+ Coverage   68.24%   68.37%   +0.12%     
==========================================
  Files         220      221       +1     
  Lines       23088    23261     +173     
==========================================
+ Hits        15757    15904     +147     
- Misses       5911     5927      +16     
- Partials     1420     1430      +10     
Flag Coverage Δ
unittests 68.37% <79.10%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/apps/v1alpha1/opsrequest_conditions.go 94.02% <ø> (ø)
...s/apps/components/stateless/component_stateless.go 0.00% <0.00%> (ø)
internal/configuration/config.go 82.32% <ø> (ø)
...pps/configuration/reconfigurerequest_controller.go 58.36% <61.90%> (+1.71%) ⬆️
...ontrollers/apps/components/util/component_utils.go 62.78% <64.78%> (+0.55%) ⬆️
controllers/apps/configuration/config_util.go 57.09% <67.56%> (-0.14%) ⬇️
controllers/apps/configuration/policy_util.go 64.57% <84.00%> (+10.20%) ⬆️
...ntrollers/apps/configuration/reconfigure_policy.go 73.91% <100.00%> (+3.03%) ⬆️
controllers/apps/configuration/simple_policy.go 91.22% <100.00%> (+1.39%) ⬆️
controllers/apps/configuration/types.go 100.00% <100.00%> (ø)
... and 5 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 25, 2023
@sophon-zt sophon-zt merged commit aa8f686 into main Jun 25, 2023
@sophon-zt sophon-zt deleted the bugfix/failed-to-start-config-manager-when-using-volumemount-with-subpath-issue3870 branch June 25, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] failed to start config-manager when using volumeMount with subpath
3 participants