Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to set helm repo url by config or environment #3905

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Jun 21, 2023

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (85a667e) 68.48% compared to head (1b2f69e) 68.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3905      +/-   ##
==========================================
- Coverage   68.48%   68.38%   -0.10%     
==========================================
  Files         220      220              
  Lines       23724    23724              
==========================================
- Hits        16247    16224      -23     
- Misses       6013     6030      +17     
- Partials     1464     1470       +6     
Flag Coverage Δ
unittests 68.38% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldming ldming merged commit 5ef506e into main Jun 27, 2023
@ldming ldming deleted the feature/cli-support-set-helm-chart-repo branch June 27, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] cli support to set default helm chart repo
4 participants