chore: fix #2738, provide zero limits resources for sidecar containers if not specified #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashtsai
requested review from
nayutah,
ldming,
heng4fun,
free6om,
dengshaojiang,
wangyelei and
leon-inf
as code owners
|
/approve |
apecloud-bot
approved these changes
Jun 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
==========================================
- Coverage 69.92% 69.89% -0.04%
==========================================
Files 235 235
Lines 25496 25513 +17
==========================================
+ Hits 17828 17832 +4
- Misses 6090 6099 +9
- Partials 1578 1582 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…s if not specified
nashtsai
force-pushed
the
support/setup-containers-limits
branch
from
862aaf9
to
216bd13
Compare
github-actions
bot
added
size/M
… this will speed up pod startup for large number of clusters
leon-inf
approved these changes
Jun 28, 2023
free6om
approved these changes
Jun 28, 2023
nayutah
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: fix #2738, provide zero limits resources for sidecar containers if not specified
chore: have workloads' pdbSpec.enableServiceLink disabled by default, this will speed up pod startup for large number of clusters