Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replicationSet parallel update strategy restart failed #4024

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

Y-Rookie
Copy link
Collaborator

@Y-Rookie Y-Rookie commented Jun 29, 2023

fix: #3966

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jun 29, 2023
@Y-Rookie Y-Rookie linked an issue Jun 29, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.02 🎉

Comparison is base (b94f6f5) 70.11% compared to head (6478935) 70.13%.

❗ Current head 6478935 differs from pull request most recent head 4adab2a. Consider uploading reports for the commit 4adab2a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4024      +/-   ##
==========================================
+ Coverage   70.11%   70.13%   +0.02%     
==========================================
  Files         235      235              
  Lines       25539    25525      -14     
==========================================
- Hits        17907    17903       -4     
+ Misses       6043     6036       -7     
+ Partials     1589     1586       -3     
Flag Coverage Δ
unittests 70.13% <76.92%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/apps/components/replication/replication_utils.go 58.38% <76.92%> (-1.12%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Y-Rookie
Copy link
Collaborator Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 29, 2023
@Y-Rookie Y-Rookie merged commit 7aa61c3 into main Jun 29, 2023
@Y-Rookie Y-Rookie deleted the bugfix/rset_parallel_update_strategy_restart_failed branch June 29, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] postgresql cluster restart error
4 participants