Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the code refactored for backup #5306

Merged
merged 9 commits into from
Oct 8, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Sep 28, 2023

Fix comments left over from PR #4917

  • Revert some incorrect changes
  • Remove some unused code
  • Use a shorter import name dpv1alpha1 to replace dataprotectionv1alpha1

@github-actions github-actions bot added this to the Release 0.7.0 milestone Sep 28, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1f87a87) 66.78% compared to head (c62228c) 66.83%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5306      +/-   ##
==========================================
+ Coverage   66.78%   66.83%   +0.04%     
==========================================
  Files         263      262       -1     
  Lines       29494    29490       -4     
==========================================
+ Hits        19699    19710      +11     
+ Misses       8254     8239      -15     
  Partials     1541     1541              
Flag Coverage Δ
unittests 66.83% <54.54%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/apps/cluster_controller.go 90.26% <100.00%> (+0.08%) ⬆️
controllers/apps/transformer_backup_policy_tpl.go 76.24% <ø> (ø)
internal/controller/plan/restore.go 65.87% <100.00%> (ø)
controllers/apps/components/component.go 0.00% <0.00%> (ø)
controllers/dataprotection/actionset_controller.go 92.50% <0.00%> (ø)
internal/dataprotection/action/action_create_vs.go 46.85% <50.00%> (ø)
internal/dataprotection/action/action_job.go 77.27% <0.00%> (ø)
internal/dataprotection/backup/deleter.go 67.08% <50.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming marked this pull request as ready for review September 28, 2023 08:56
@ldming
Copy link
Collaborator Author

ldming commented Oct 1, 2023

/approve to trigger test

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 1, 2023
@ldming
Copy link
Collaborator Author

ldming commented Oct 7, 2023

/approve

@ldming
Copy link
Collaborator Author

ldming commented Oct 7, 2023

/approve

@ldming
Copy link
Collaborator Author

ldming commented Oct 8, 2023

/approve

@ldming ldming merged commit 319141d into main Oct 8, 2023
56 of 59 checks passed
@ldming ldming deleted the support/improve-backup-refactor branch October 8, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test refactor size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants