chore: support leave member by using any pods #7890
Conversation
newborn22
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
|
|
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
| // For the purpose of upgrade compatibility, if the version of Lorry is 0.7 and | ||
| // the version of KB is upgraded to 0.8 or newer, lorry client will return an NotImplemented error, | ||
| // in this case, here just ignore it. | ||
| if err2 == lorry.NotImplemented { | ||
| r.reqCtx.Log.Info("lorry leave member api is not implemented") | ||
| } else if unableToConnect(err2) { |
There was a problem hiding this comment.
When a pod is pending, new lorry clients may encounter issues. This situation can also be resolved here.
| // remove current member from db cluster | ||
| err = manager.LeaveMemberFromCluster(ctx, cluster, manager.GetCurrentMemberName()) | ||
| // remove member from db cluster, the member may be other pod, depending on if podName is assigned in req.Parameters | ||
| err = manager.LeaveMemberFromCluster(ctx, cluster, memberNameToLeave) |
There was a problem hiding this comment.
This change in the API can be reflected in the DBManager interface.
| if err2 := lorryCli.LeaveMember(r.reqCtx.Ctx, nil); err2 != nil { | ||
| // For the purpose of upgrade compatibility, if the version of Lorry is 0.7 and | ||
| // the version of KB is upgraded to 0.8 or newer, lorry client will return an NotImplemented error, | ||
| // in this case, here just ignore it. | ||
| if err2 == lorry.NotImplemented { | ||
| r.reqCtx.Log.Info("lorry leave member api is not implemented") | ||
| } else if unableToConnect(err2) { | ||
| r.reqCtx.Log.Info(fmt.Sprintf("when leaving pod %s by lorry, can not connect lorry on pod %s, try to leave member by other pods", pod.Name, pod.Name)) | ||
| err3 := r.leaveMemberByOtherPods(desiredPods, pod) | ||
| if err == nil { | ||
| err = err3 | ||
| } |
There was a problem hiding this comment.
re-org lorryCli.LeaveMember, unableToConnect and r.leaveMemberByOtherPods into one single method of r seems more readable.
free6om
changed the title
|
This branch name is not following the standards: feature/|bugfix/|release/|hotfix/|support/|releasing/|dependabot/ |
|
fixed #7753 |
| parameters["podName"] = podToLeave.Spec.Hostname | ||
|
|
||
| for _, pod := range desiredPods { | ||
| lorryCli, err1 := lorry.NewClient(*pod) |
There was a problem hiding this comment.
It should follow the API definition, otherwise there will be risks in executing the action on other pods.
related issue: #7753