Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support InstanceSet PVC ownerReference #8064

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Aug 30, 2024

fixed #7846

@free6om free6om self-assigned this Aug 30, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 30, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 4, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (4f74673) to head (1bccd86).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/instanceset/instance_util.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8064      +/-   ##
==========================================
+ Coverage   62.49%   62.54%   +0.04%     
==========================================
  Files         333      333              
  Lines       40569    40551      -18     
==========================================
+ Hits        25354    25362       +8     
+ Misses      12946    12921      -25     
+ Partials     2269     2268       -1     
Flag Coverage Δ
unittests 62.54% <72.72%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 9, 2024
@free6om free6om merged commit d71c88e into main Sep 9, 2024
58 checks passed
@free6om free6om deleted the support/its-pvc-ower-reference branch September 9, 2024 08:58
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 9, 2024
@free6om
Copy link
Contributor Author

free6om commented Sep 9, 2024

/cherry-pick release-0.9

Copy link

github-actions bot commented Sep 9, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/10769943128

@free6om free6om restored the support/its-pvc-ower-reference branch September 9, 2024 09:00
@free6om free6om deleted the support/its-pvc-ower-reference branch September 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Make InstanceSet controller set ownerReferences on PersistentVolumeClaims
5 participants