Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support InstanceSet PVC ownerReference #8113

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Sep 9, 2024

No description provided.

@free6om free6om added this to the Release 0.9.1 milestone Sep 9, 2024
@free6om free6om self-assigned this Sep 9, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 9, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.10%. Comparing base (714c83d) to head (efe12ab).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/instanceset/instance_util.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8113      +/-   ##
===============================================
- Coverage        65.17%   65.10%   -0.07%     
===============================================
  Files              357      357              
  Lines            44819    44801      -18     
===============================================
- Hits             29209    29169      -40     
- Misses           13024    13032       +8     
- Partials          2586     2600      +14     
Flag Coverage Δ
unittests 65.10% <72.72%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om
Copy link
Contributor Author

free6om commented Sep 9, 2024

/approve

@free6om free6om merged commit dc46575 into release-0.9 Sep 9, 2024
65 of 67 checks passed
@free6om free6om deleted the support/its-pvc-ower-reference-0.9 branch September 9, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants