Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the support for generated components #8154

Merged
merged 31 commits into from
Sep 20, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf marked this pull request as ready for review September 14, 2024 06:53
@leon-inf leon-inf added this to the Release 1.0.0 milestone Sep 14, 2024
@leon-inf leon-inf force-pushed the support/cleanup-generated-component branch 2 times, most recently from 1765329 to f14ffeb Compare September 14, 2024 07:18
@leon-inf leon-inf force-pushed the support/cleanup-generated-component branch from f14ffeb to f7ab935 Compare September 14, 2024 07:31
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 59.68254% with 127 lines in your changes missing coverage. Please review.

Project coverage is 61.36%. Comparing base (a63502a) to head (f92b88f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/service_reference.go 56.29% 98 Missing and 13 partials ⚠️
controllers/apps/operations/switchover.go 0.00% 9 Missing ⚠️
pkg/controller/component/synthesize_component.go 70.00% 2 Missing and 1 partial ⚠️
...ers/apps/configuration/configuration_controller.go 75.00% 0 Missing and 2 partials ⚠️
...rs/apps/transformer_component_account_provision.go 0.00% 0 Missing and 1 partial ⚠️
...ollers/apps/transformer_component_pre_terminate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8154      +/-   ##
==========================================
+ Coverage   60.98%   61.36%   +0.37%     
==========================================
  Files         359      358       -1     
  Lines       41458    41282     -176     
==========================================
+ Hits        25284    25331      +47     
+ Misses      13903    13703     -200     
+ Partials     2271     2248      -23     
Flag Coverage Δ
unittests 61.36% <59.68%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zjx20
zjx20 previously approved these changes Sep 18, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 18, 2024
Y-Rookie
Y-Rookie previously approved these changes Sep 20, 2024
@leon-inf leon-inf force-pushed the support/refine-cluster-component-v1-api branch from 9e1cca9 to a82da0e Compare September 20, 2024 03:37
Base automatically changed from support/refine-cluster-component-v1-api to main September 20, 2024 04:10
@leon-inf leon-inf dismissed stale reviews from Y-Rookie and zjx20 September 20, 2024 04:10

The base branch was changed.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 20, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 20, 2024
@leon-inf leon-inf force-pushed the support/cleanup-generated-component branch from 6b38e37 to f92b88f Compare September 20, 2024 05:21
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 20, 2024
@leon-inf leon-inf merged commit 240bbf8 into main Sep 20, 2024
36 checks passed
@leon-inf leon-inf deleted the support/cleanup-generated-component branch September 20, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants