Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove CV update validation #8173

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: remove CV update validation #8173

merged 1 commit into from
Sep 20, 2024

Conversation

shanshanying
Copy link
Contributor

@shanshanying shanshanying commented Sep 20, 2024 •
edited
Loading

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 20, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 20, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.00%. Comparing base (0a4aaac) to head (3d0db4d).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
apis/apps/v1alpha1/clusterversion_webhook.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-0.9    #8173      +/-   ##
===============================================
- Coverage        65.07%   65.00%   -0.07%     
===============================================
  Files              358      358              
  Lines            45108    45108              
===============================================
- Hits             29355    29324      -31     
- Misses           13145    13168      +23     
- Partials          2608     2616       +8
Flag Coverage Δ
unittests 65.00% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanshanying shanshanying merged commit 4a02a0c into release-0.9 Sep 20, 2024
43 checks passed
@shanshanying shanshanying deleted the support/webhook-disable-cv-validation branch September 20, 2024 07:05
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JashBook JashBook JashBook approved these changes

@wangyelei wangyelei wangyelei approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
5 participants
@shanshanying @wangyelei @JashBook @apecloud-bot @wusai80