Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the Halt termination policy type #8202

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

leon-inf
Copy link
Contributor

No description provided.

@leon-inf leon-inf requested review from Y-Rookie and a team as code owners September 25, 2024 02:35
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (665e033) to head (188b9ca).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
apis/apps/v1alpha1/cluster_conversion.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8202      +/-   ##
==========================================
+ Coverage   60.82%   61.16%   +0.33%     
==========================================
  Files         352      350       -2     
  Lines       40786    40621     -165     
==========================================
+ Hits        24808    24845      +37     
+ Misses      13725    13528     -197     
+ Partials     2253     2248       -5     
Flag Coverage Δ
unittests 61.16% <41.66%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 25, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Sep 25, 2024
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 26, 2024
@leon-inf leon-inf merged commit beedc37 into main Sep 26, 2024
36 checks passed
@leon-inf leon-inf deleted the support/remove-halt branch September 26, 2024 01:46
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants