feat: introduce the available probe and condition for component #8212

leon-inf · 2024-09-26T07:00:33Z

No description provided.

codecov · 2024-09-26T07:14:40Z

Codecov Report

Attention: Patch coverage is 50.26738% with 279 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (528f5ab) to head (6f6ab9d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/component/available.go	51.00%	176 Missing and 20 partials ⚠️
pkg/kbagent/service/probe.go	1.61%	61 Missing ⚠️
pkg/controller/component/kbagent.go	37.50%	9 Missing and 1 partial ⚠️
controllers/apps/transformer_component_status.go	78.78%	5 Missing and 2 partials ⚠️
controllers/apps/componentdefinition_controller.go	93.33%	2 Missing and 1 partial ⚠️
pkg/controller/component/workload_utils.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8212      +/-   ##
==========================================
- Coverage   61.25%   61.23%   -0.02%     
==========================================
  Files         350      351       +1     
  Lines       41256    41777     +521     
==========================================
+ Hits        25270    25583     +313     
- Misses      13705    13891     +186     
- Partials     2281     2303      +22

Flag	Coverage Δ
unittests	`61.23% <50.26%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zjx20 · 2024-09-28T12:31:39Z

pkg/controller/component/available.go

+			break
+		}
+	}
+	if idx >= 0 && h.condEqual(comp.Status.Conditions[idx], newCond) {


can use helpers functions from https://github.com/kubernetes/apimachinery/blob/master/pkg/api/meta/conditions.go .

pkg/kbagent/service/probe.go

zjx20 · 2024-10-28T06:44:42Z

pkg/controller/component/available.go

+		for _, podEvents := range events {
+			if len(podEvents) > 1 {
+				slices.SortFunc(podEvents, func(evt1, evt2 probeEvent) int {
+					switch {


This may help.
https://pkg.go.dev/time#Time.Compare

It doesn't need to sort the whole slice if it only needs the latest one.

zjx20 · 2024-10-28T07:05:18Z

pkg/controller/component/available.go

+	return true
+}
+
+func (h *AvailableEventHandler) evaluateConditionX(cond appsv1.ComponentAvailableConditionX, replicas int32, events []probeEvent) (bool, string, error) {


The last two returned values are always empty, maybe just remove them.

The returned error has been deleted, and the message is retained to convey detailed information when it is unavailable. It will be added later.

zjx20 · 2024-10-28T07:11:43Z

apis/apps/v1/componentdefinition_types.go

+	// This field is immutable once set.
+	//
+	// +optional
+	TimeWindow *int32 `json:"timeWindow,omitempty"`


Declare the unit of the field.

leon-inf · 2024-10-29T08:54:27Z

/approve

leon-inf · 2024-10-31T04:48:26Z

/approve

leon-inf · 2024-11-01T02:14:38Z

/approve

zjx20

LGTM

zjx20 · 2024-11-01T05:19:52Z

pkg/controller/component/available.go

@@ -283,7 +271,7 @@ func (h *AvailableEventHandler) getCachedEvents(comp *appsv1.Component) ([]probe
 }

 func (h *AvailableEventHandler) updateCachedEvents(comp *appsv1.Component, events []probeEvent) error {
-	if comp.Annotations == nil && len(events) == 0 {
+	if comp.Status.Message == nil && len(events) == 0 {


unnecessary to check comp.Status.Message == nil?

It needs to delete expired events.

leon-inf · 2024-11-01T05:48:02Z

/cherry-pick release-1.0-beta

github-actions · 2024-11-01T05:48:22Z

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/11625004010

(cherry picked from commit c3968ca)

leon-inf added 2 commits September 26, 2024 14:55

feat: introduce the available probe and condition for the component

31233ec

Merge branch 'main' into feature/available-probe-and-conditions

b9bc884

leon-inf requested review from Y-Rookie and a team as code owners September 26, 2024 07:00

github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 26, 2024

fix lint

96d3fdd

leon-inf force-pushed the feature/available-probe-and-conditions branch from 7df4c0f to c7faf48 Compare September 26, 2024 08:25

leon-inf marked this pull request as draft September 26, 2024 08:29

update

173961c

leon-inf force-pushed the feature/available-probe-and-conditions branch from c7faf48 to 173961c Compare September 26, 2024 10:07

github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 26, 2024

Merge branch 'main' into feature/available-probe-and-conditions

8a3b6aa

zjx20 reviewed Sep 28, 2024

View reviewed changes

update

41a0e44

leon-inf force-pushed the feature/available-probe-and-conditions branch from 1f6a406 to 41a0e44 Compare October 8, 2024 01:44

leon-inf added 7 commits October 23, 2024 17:58

Merge branch 'main' into feature/available-probe-and-conditions

f834c38

update

31ccaf2

revert changes to phases

c128788

available condition from phases

228a215

ut for cmpd

d46287c

pickup events

fc426c6

Merge branch 'main' into feature/available-probe-and-conditions

25c5150

leon-inf changed the title ~~feat: introduce the available probe and condition~~ feat: introduce the available probe and condition for component Oct 28, 2024

leon-inf marked this pull request as ready for review October 28, 2024 03:14

update

4339fe6

leon-inf force-pushed the feature/available-probe-and-conditions branch from 70aa5b9 to 4339fe6 Compare October 28, 2024 03:25

ut for available event handler

bc69516

zjx20 reviewed Oct 28, 2024

View reviewed changes

apecloud-bot removed the approved PR Approved Test label Oct 29, 2024

apecloud-bot approved these changes Oct 29, 2024

View reviewed changes

apecloud-bot added the approved PR Approved Test label Oct 29, 2024

update

ee235f4

apecloud-bot removed the approved PR Approved Test label Oct 30, 2024

leon-inf added 2 commits October 31, 2024 12:40

update

ffd74d7

Merge branch 'main' into feature/available-probe-and-conditions

bbbf47c

apecloud-bot approved these changes Oct 31, 2024

View reviewed changes

apecloud-bot added approved PR Approved Test and removed approved PR Approved Test labels Oct 31, 2024

leon-inf force-pushed the feature/available-probe-and-conditions branch 2 times, most recently from 13c7103 to 2e2d1f9 Compare October 31, 2024 07:15

update

a2c9f00

leon-inf force-pushed the feature/available-probe-and-conditions branch from 2e2d1f9 to a2c9f00 Compare October 31, 2024 07:17

leon-inf added this to the Release 1.0.0 milestone Oct 31, 2024

apecloud-bot approved these changes Nov 1, 2024

View reviewed changes

apecloud-bot added the approved PR Approved Test label Nov 1, 2024

leon-inf added 2 commits November 1, 2024 12:27

update

174e6de

Merge branch 'main' into feature/available-probe-and-conditions

6f6ab9d

apecloud-bot removed the approved PR Approved Test label Nov 1, 2024

zjx20 approved these changes Nov 1, 2024

View reviewed changes

apecloud-bot added the approved PR Approved Test label Nov 1, 2024

leon-inf merged commit c3968ca into main Nov 1, 2024
36 checks passed

leon-inf deleted the feature/available-probe-and-conditions branch November 1, 2024 05:47

github-actions bot pushed a commit that referenced this pull request Nov 1, 2024

feat: introduce the available probe and condition for component (#8212)

06f5c24

(cherry picked from commit c3968ca)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce the available probe and condition for component #8212

feat: introduce the available probe and condition for component #8212

leon-inf commented Sep 26, 2024

codecov bot commented Sep 26, 2024 •

edited

Loading

zjx20 Sep 28, 2024

leon-inf Oct 28, 2024

zjx20 Oct 28, 2024

zjx20 Oct 28, 2024

leon-inf Oct 28, 2024

zjx20 Oct 28, 2024

leon-inf Oct 28, 2024

zjx20 Oct 28, 2024

leon-inf Oct 28, 2024

leon-inf commented Oct 29, 2024

leon-inf commented Oct 31, 2024

leon-inf commented Nov 1, 2024

zjx20 left a comment

zjx20 Nov 1, 2024

leon-inf Nov 1, 2024

leon-inf commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

feat: introduce the available probe and condition for component #8212

feat: introduce the available probe and condition for component #8212

Conversation

leon-inf commented Sep 26, 2024

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leon-inf commented Oct 29, 2024

leon-inf commented Oct 31, 2024

leon-inf commented Nov 1, 2024

zjx20 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leon-inf commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

codecov bot commented Sep 26, 2024 •

edited

Loading