chore: set clusterdefinition.componentDefs default to empty list #8227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shanshanying
commented
Sep 29, 2024
shanshanying
commented
shanshanying
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
Y-Rookie
as code owners
wangyelei
approved these changes
Sep 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #8227 +/- ##
===============================================
- Coverage 65.03% 65.01% -0.02%
===============================================
Files 358 358
Lines 45184 45184
===============================================
- Hits 29384 29376 -8
- Misses 13190 13201 +11
+ Partials 2610 2607 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Y-Rookie
approved these changes
Sep 29, 2024
shanshanying
deleted the
support/set-clusterdef-componentDefs-default-to-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.