Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: service-ref supports to refer services from different namespace #8245

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Oct 9, 2024

resolve #7417

@leon-inf leon-inf requested a review from a team as a code owner October 9, 2024 02:58
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 9, 2024
@leon-inf leon-inf added this to the Release 1.0.0 milestone Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (708cb8d) to head (c314d82).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/component/service_reference.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8245      +/-   ##
==========================================
+ Coverage   61.18%   61.37%   +0.19%     
==========================================
  Files         348      348              
  Lines       40268    40277       +9     
==========================================
+ Hits        24639    24722      +83     
+ Misses      13385    13325      -60     
+ Partials     2244     2230      -14     
Flag Coverage Δ
unittests 61.37% <94.44%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 9, 2024
@leon-inf leon-inf merged commit 93ad2c1 into main Oct 9, 2024
41 checks passed
@leon-inf leon-inf deleted the support/service-ref-cross-namespace-service branch October 9, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
4 participants