Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use generic sets instead of the deprecated one #8251

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

zjx20
Copy link
Contributor

@zjx20 zjx20 commented Oct 9, 2024

Closes #8237.

@zjx20 zjx20 requested a review from a team as a code owner October 9, 2024 09:39
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.52%. Comparing base (5cc108f) to head (64d449b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pkg/common/env_resolve.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8251      +/-   ##
==========================================
+ Coverage   61.18%   61.52%   +0.34%     
==========================================
  Files         348      348              
  Lines       40315    40416     +101     
==========================================
+ Hits        24665    24866     +201     
+ Misses      13407    13314      -93     
+ Partials     2243     2236       -7     
Flag Coverage Δ
unittests 61.52% <71.42%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 10, 2024
@zjx20
Copy link
Contributor Author

zjx20 commented Oct 12, 2024

/approve

@zjx20 zjx20 merged commit d218db1 into main Oct 12, 2024
38 checks passed
@zjx20 zjx20 deleted the support/use-generic-sets branch October 12, 2024 06:10
@github-actions github-actions bot added this to the Release 0.9.2 milestone Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Use generic Set to replace specified sets
3 participants