Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unused import #8413

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: unused import #8413

merged 1 commit into from
Nov 6, 2024

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Nov 6, 2024

After #8378 and #8400 merged concurrently, there has been an unused import that breaks the build.

@cjc7373 cjc7373 requested a review from a team as a code owner November 6, 2024 06:57
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 6, 2024
@cjc7373 cjc7373 changed the title fix: unused import chore: unused import Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.38%. Comparing base (67a0f6f) to head (36822e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8413      +/-   ##
==========================================
+ Coverage   61.01%   61.38%   +0.36%     
==========================================
  Files         351      351              
  Lines       41801    41739      -62     
==========================================
+ Hits        25505    25620     +115     
+ Misses      13980    13813     -167     
+ Partials     2316     2306      -10     
Flag Coverage Δ
unittests 61.38% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjx20
Copy link
Contributor

zjx20 commented Nov 6, 2024

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 6, 2024
@cjc7373 cjc7373 merged commit 9613375 into main Nov 6, 2024
40 of 41 checks passed
@cjc7373 cjc7373 deleted the bugfix/unused-import branch November 6, 2024 15:12
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 6, 2024
wangyelei pushed a commit that referenced this pull request Nov 11, 2024
(cherry picked from commit 9613375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants