Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to delete failed backups when deleting cluster #8435

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners November 11, 2024 03:36
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.35%. Comparing base (0d4a0b5) to head (307c463).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/transform_utils.go 43.75% 8 Missing and 1 partial ⚠️
controllers/apps/transformer_cluster_deletion.go 44.44% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8435      +/-   ##
==========================================
+ Coverage   61.12%   61.35%   +0.22%     
==========================================
  Files         351      351              
  Lines       41743    41764      +21     
==========================================
+ Hits        25517    25623     +106     
+ Misses      13927    13828      -99     
- Partials     2299     2313      +14     
Flag Coverage Δ
unittests 61.35% <50.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 11, 2024
@wangyelei wangyelei merged commit 21fa706 into main Nov 11, 2024
38 checks passed
@wangyelei wangyelei deleted the bugfix/cluster_deleting branch November 11, 2024 05:46
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 11, 2024
wangyelei added a commit that referenced this pull request Nov 11, 2024
ian-hui pushed a commit to ian-hui/kubeblocks that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants