chore: refactor 1.0 parameter api #8441
Open
+16,876
−10,369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-inf
reviewed
Nov 12, 2024
| @@ -143,6 +143,8 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct | |||
| &clusterServiceTransformer{}, | |||
| // handle the restore for cluster | |||
| &clusterRestoreTransformer{}, | |||
| // rerender parameters after v-scale and h-scale | |||
| &clusterParametersTransformer{}, | |||
There was a problem hiding this comment.
It should be moved out of the cluster controller since the apps package has no knowledge about the parameters and doesn't depend on it too.
leon-inf
reviewed
Nov 12, 2024
| return nil | ||
| } | ||
|
|
||
| configRender, paramsDefs, err := intctrlutil.ResolveCmpdParametersDefs(transCtx, transCtx.Client, transCtx.CompDef) |
leon-inf
reviewed
Nov 12, 2024
| @@ -318,7 +318,7 @@ type ComponentDefinitionSpec struct { | |||
| // +listType=map | |||
| // +listMapKey=name | |||
| // +optional | |||
| Configs []ComponentConfigSpec `json:"configs,omitempty"` | |||
| Configs []ComponentTemplateSpec `json:"configs,omitempty"` | |||
There was a problem hiding this comment.
The ComponentConfigSpec could be deleted from this package?
leon-inf
reviewed
Nov 12, 2024
| // Specifies the initialization parameters. | ||
| // | ||
| // +optional | ||
| InitParameters ComponentParameters `json:"initParameters,omitempty"` |
There was a problem hiding this comment.
It should be added into spec.components.configs, and be used as init values to render config templates.
…o parameters controller
sophon-zt
force-pushed
the
support/improvement-10-config-related-api-issue8298
branch
from
7455b95
to
cd36433
Compare
sophon-zt
requested review from
ldming,
wangyelei,
zjx20,
a team and
Y-Rookie
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.