-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward logs to Loki #129
Merged
Merged
Forward logs to Loki #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Nov 22, 2023
packages/api/deployment/signed-api-cloudformation-template.json
Outdated
Show resolved
Hide resolved
Siegrift
commented
Nov 22, 2023
packages/api/deployment/signed-api-cloudformation-template.json
Outdated
Show resolved
Hide resolved
Siegrift
force-pushed
the
deployment-template
branch
from
November 22, 2023 18:04
be5c1b1
to
484d93b
Compare
Siegrift
force-pushed
the
deployment-template
branch
from
November 22, 2023 18:07
484d93b
to
bf6d0f3
Compare
Siegrift
force-pushed
the
loki-forward
branch
from
November 25, 2023 09:06
588c3d3
to
5730a97
Compare
Siegrift
force-pushed
the
loki-forward
branch
from
January 18, 2024 16:15
5730a97
to
abd6be7
Compare
Siegrift
commented
Jan 18, 2024
Siegrift
force-pushed
the
loki-forward
branch
from
January 18, 2024 16:20
abd6be7
to
f483d0a
Compare
bdrhn9
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Siegrift
force-pushed
the
loki-forward
branch
from
January 19, 2024 08:59
dc6bf77
to
8adcdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123
Rationale
Implement the same Loki integration as is in https://github.com/api3dao/api-integrations/blob/main/data/cloudformation-template.json.
I tested by deploying the template (with few values edited) and Bedirhan confirmed the logs are recieved by Loki.