Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward logs to Loki #129

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Forward logs to Loki #129

merged 2 commits into from
Jan 19, 2024

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Nov 22, 2023

Closes #123

Rationale

Implement the same Loki integration as is in https://github.com/api3dao/api-integrations/blob/main/data/cloudformation-template.json.

I tested by deploying the template (with few values edited) and Bedirhan confirmed the logs are recieved by Loki.

@Siegrift Siegrift self-assigned this Nov 22, 2023
@Siegrift Siegrift changed the title WIP: Forward logs to Loki Forward logs to Loki Nov 22, 2023
@Siegrift Siegrift requested review from bdrhn9 and metobom November 22, 2023 11:59
@Siegrift Siegrift force-pushed the deployment-template branch from be5c1b1 to 484d93b Compare November 22, 2023 18:04
@Siegrift Siegrift force-pushed the deployment-template branch from 484d93b to bf6d0f3 Compare November 22, 2023 18:07
Base automatically changed from deployment-template to main November 22, 2023 18:13
@Siegrift Siegrift added the on hold We do not plan to address this at the moment label Nov 30, 2023
@Siegrift Siegrift removed the request for review from metobom January 18, 2024 16:16
@Siegrift Siegrift removed the on hold We do not plan to address this at the moment label Jan 18, 2024
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@Siegrift Siegrift merged commit 6b2cf90 into main Jan 19, 2024
4 checks passed
@Siegrift Siegrift deleted the loki-forward branch January 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Loki forwarding to signed API CF template
2 participants