Increase payload size, add default express error handler #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, we'll push batches of 100 https://api3workspace.slack.com/archives/C01UR36T91V/p1701440527097619 |
|
Thanks. For full context the signed data is roughly ~400 bytes, so for 100kb we could do 100000 / 400 = 250, with 10mb we can do 10000000 / 400 = 25000. I think 1mb would also suffice for practical purposes, but I'd leave it set to 10mb. |
|
Would you be able to update this branch to make it a bit easier to review please? |
Siegrift
force-pushed
the
payload-limit
branch
from
d175543 to
12e4a80
Compare
Siegrift
force-pushed
the
payload-limit
branch
from
12e4a80 to
7ba8b6d
Compare
andreogle
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
Rationale
I've set the maximum payload limit to 10mb which should be more then enough for practical use cases. The higher the limit is the bigger is the risk of Signed API being spammed by attackers. We have Airnode allowlist in the config, but even processing such huge payloads incurs some overhead.
I've also added an e2e test that validates this.